CommentFileSizeAuthor
#7 3151632-7-void-return-type-hint.patch1.92 KBtr
#2 3151632-2.patch1.48 KBpavnish

Comments

pavnish created an issue. See original summary.

pavnish’s picture

pavnish commented
Assigned: pavnish » Unassigned
Status: Active » Needs review
StatusFileSize
new 3151632-2.patch1.48 KB

Could you please review this patch

krzysztof domański’s picture

krzysztof domański
Location Poland
commented
Status: Needs review » Reviewed & tested by the community

Overridden test methods require void return type hints

tr’s picture

tr commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

This is really a D9 change. In order for this to work in D8 it requires that Voting API increase the PHP requirement to 7.1, which is higher than Drupal core PHP requirement. I'm strongly against imposing requirements different than Drupal core.

krzysztof domański’s picture

krzysztof domański
Location Poland
commented
Status: Postponed (maintainer needs more info) » Postponed

Right, Drupal 8.9 still supports PHP 7.0 so it should be postponed until we suport Drupal 8. Drupal 8 will be supported until November 2021.

tr’s picture

tr commented
Status: Postponed » Needs review

Re-opening now that D8 is EOL and no longer supported. Let's see whether this still applies.

tr’s picture

tr commented
StatusFileSize
new 3151632-7-void-return-type-hint.patch1.92 KB

Patch still applies but it misses fixing one test case. Not surprising, because that test case was written long after the patch was posted.

Here's a new patch that should do the trick.

  • TR committed 807006f on 8.x-3.x 
    Issue #3151632 by pavnish, TR: Add void return typehint to test setUp...
tr’s picture

tr commented
Status: Needs review » Fixed

Committed #7.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.