Problem/Motivation

It was recently added token Support for average and count in the issue https://www.drupal.org/project/votingapi/issues/2961079.
It would be great to cover this extra functionality with tests.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3117091-6-votingapi-tokens-tests.patch3.42 KBtr
#5 3117091-5-votingapi-tokens-tests.patch3.42 KBtr
#4 votingapi-tokens-tests-3117091-4.patch3.38 KBandralex
#2 votingapi-tokens-tests-3117091-2.patch0 bytesandralex

Comments

andralex created an issue. See original summary.

andralex’s picture

andralex commented
StatusFileSize
new votingapi-tokens-tests-3117091-2.patch0 bytes

Let's see on this patch

andralex’s picture

andralex commented
Assigned: andralex » Unassigned
Status: Active » Needs review
andralex’s picture

andralex commented
StatusFileSize
new votingapi-tokens-tests-3117091-4.patch3.38 KB
tr’s picture

tr commented
Issue tags: -Needs tests
StatusFileSize
new 3117091-5-votingapi-tokens-tests.patch3.42 KB

Yes! More tests are sorely needed! The more the better.

However, the patch in 4 needs to be changed a bit. The reason it didn't get tested in #2 or #4 is because the namespace of the test in the patch was wrong. Also the patch adds two coding standards violations. I fixed these - here is a new patch that fixes these problems and should Run and Pass on DrupalCI.

tr’s picture

tr commented
StatusFileSize
new 3117091-6-votingapi-tokens-tests.patch3.42 KB

#5 tested green but didn't actually fix the coding standards that I intended it to. So here's a new patch:

tr’s picture

tr commented

Test results in #6 shows that all test passed with no coding standards violations.

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Needs review » Reviewed & tested by the community

  • pifagor committed f888752 on 8.x-3.x authored by TR 
    Issue #3117091 by andralex, TR, pifagor: Add test coverage for...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.