Vote::postSave() overrides ContentEntityBase::postSave() without calling the parent method. Because of that, a couple of things that should run don't. Most importantly the list cache tag for votes is not invalidated, so that views e.g. views of votes are not re-calculated when a new vote is created.

CommentFileSizeAuthor
#19 2898847-cache-tags-to-invalidate-beta-2-19.patch1.8 KBa.dmitriiev
#19 2898847-cache-tags-to-invalidate-19.patch731 bytesa.dmitriiev
#12 interdiff-2898847-10-12.txt325 bytesmrinalini9
#12 2898847-12.patch1.09 KBmrinalini9
#10 2898847-10.patch891 bytesmrinalini9
#5 2898847-5.patch792 bytesrpayanm
#2 2898847-2.patch787 byteststoeckler

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review
StatusFileSize
new 2898847-2.patch787 bytes

This fixes the issue for me, simply by calling the parent function.

dunebl’s picture

dunebl
Primary language French
commented

I think this patch needs to be rerolled:

patching file src/Entity/Vote.php
Hunk #1 FAILED at 256.
Hunk #2 succeeded at 262 (offset -3 lines).
1 out of 2 hunks FAILED -- saving rejects to file src/Entity/Vote.php.rej
idebr’s picture

idebr commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 2898847-5.patch792 bytes
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Issue tags: -Needs reroll
hkirsman’s picture

hkirsman commented

Was going to remove the caching myself until saw this - smarter fix :)

Tx!

hkirsman’s picture

hkirsman commented
Status: Needs review » Reviewed & tested by the community
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Needs work
mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new 2898847-10.patch891 bytes

Rerolled patch #5 for 8.x-3.x branch as it failed to apply, please review.

tr’s picture

tr commented
Status: Needs review » Needs work 
src/Entity/Vote.php ✗ 1 more
line 5	Unused use statement
mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new 2898847-12.patch1.09 KB
new interdiff-2898847-10-12.txt325 bytes

Removed unused use statement as per mentioned in #11, please review.

tr’s picture

tr commented
Status: Needs review » Reviewed & tested by the community

Looks good!

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented

  • pifagor committed 101b793 on 8.x-3.x authored by mrinalini9 
    Issue #2898847 by mrinalini9, tstoeckler, rpayanm, pifagor, TR, hkirsman...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

a.dmitriiev’s picture

a.dmitriiev commented

Thanks for the fix, when it will be in the stable version?

I would also like to know why these lines were removed:

$cache_tag = $this->getVotedEntityType() . ':' . $this->getVotedEntityId();
 Cache::invalidateTags([$cache_tag]);

Does voted entity already include the vote cache tags? For example, will the page with cache for the node, that I am rating, be updated after the vote is added/updated?

a.dmitriiev’s picture

a.dmitriiev commented
StatusFileSize
new 2898847-cache-tags-to-invalidate-19.patch731 bytes
new 2898847-cache-tags-to-invalidate-beta-2-19.patch1.8 KB

Maybe it is good idea to keep those tags in the list of the ones that should be invalidated? I also re-rolled the patch for 8.x-3.0-beta2 because the fix is not in a stable version.