Vote's value type should be fetched from the vote type not default to 'percent' [#2897495]

Vote's value_type field, has a default value of percent. This is fairly arbitrary. Instead, I think, the value that is configured as part of the vote type should be used. A default value callback could be used for that.

Comment	File	Size	Author
#4	2897495-4-default-value-type.patch	1.37 KB	TR
#4	8.x-3.x: PHP 7.2 & MySQL 5.7, D8.9 3 pass, 2 fail
#2	2897495-2.patch	1.01 KB	tstoeckler
#2	8.x-3.x: PHP 5.3 & MySQL 5.5, D8.5 Unable to start phantomjs PHP 5.6 & MySQL 5.5, D8.6 Patch Failed to Apply PHP 5.5 & MySQL 5.5, D8.6 Patch Failed to Apply PHP 7.2 & MySQL 5.7, D8.9 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

26 July 2017 at 10:15

tstoeckler created an issue. See original summary.

Comment #2

tstoeckler

he/him

German

Essen, Germany

CreditAttribution: tstoeckler commented 26 July 2017 at 10:16

Status:

Active

» Needs review

File	Size
2897495-2.patch	1.01 KB
8.x-3.x: PHP 5.3 & MySQL 5.5, D8.5 Unable to start phantomjs PHP 5.6 & MySQL 5.5, D8.6 Patch Failed to Apply PHP 5.5 & MySQL 5.5, D8.6 Patch Failed to Apply PHP 7.2 & MySQL 5.7, D8.9 Patch Failed to Apply

This seems to work for me.

Comment #3

TR CreditAttribution: TR commented 29 April 2020 at 20:07

Status:

Needs review

» Needs work

Patch no longer applies and needs to be rerolled.

Comment #4

TR CreditAttribution: TR commented 27 May 2020 at 03:43

Status:	Needs work	» Needs review
Related issues:		+#3020977: Misleading description of Value type

File	Size
2897495-4-default-value-type.patch	1.37 KB
8.x-3.x: PHP 7.2 & MySQL 5.7, D8.9 3 pass, 2 fail

1 file was hidden/shown/deleted

File	Size
2897495-2.patch	1.01 KB
8.x-3.x: PHP 5.3 & MySQL 5.5, D8.5 Unable to start phantomjs PHP 5.6 & MySQL 5.5, D8.6 Patch Failed to Apply PHP 5.5 & MySQL 5.5, D8.6 Patch Failed to Apply PHP 7.2 & MySQL 5.7, D8.9 Patch Failed to Apply

Here's a re-roll and an update. This seems like a good clean up and gets us one step closer to properly dealing with values stored in value_type. See the related issue for more discussion about value_type.