Vote's value_type field, has a default value of percent. This is fairly arbitrary. Instead, I think, the value that is configured as part of the vote type should be used. A default value callback could be used for that.

CommentFileSizeAuthor
#4 2897495-4-default-value-type.patch1.37 KBtr
#2 2897495-2.patch1.01 KBtstoeckler

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review
StatusFileSize
new 2897495-2.patch1.01 KB

This seems to work for me.

tr’s picture

tr commented
Status: Needs review » Needs work

Patch no longer applies and needs to be rerolled.

tr’s picture

tr commented
Status: Needs work » Needs review
Related issues: +#3020977: Misleading description of Value type
StatusFileSize
new 2897495-4-default-value-type.patch1.37 KB

Here's a re-roll and an update. This seems like a good clean up and gets us one step closer to properly dealing with values stored in value_type. See the related issue for more discussion about value_type.

Status: Needs review » Needs work

The last submitted patch, 4: 2897495-4-default-value-type.patch, failed testing. View results