Vote rollover settings are missing the "Never" option

Actually, this setting was not implemented for D8 version.
I've implemented this setting in the Vote->save()

Before save a vote, I'm checking if there is a vote in the time window.
If there is, the previous vote is deleted and the new vote is saved.

Here's a patch.

Sorry, I found a bug in the previous patch.
Please, check out the following patch.

In my opinion this setting is too granular to be applied on a global space. The setting can/ should be a default for widgets to act on. But enforcing the the same rollover configuration on all votes, vote types, fields is probably not a good idea. Imagine a website on which you have multiple votes with different rules when a vote shall be counted as a new vote, this couldn't be solved once this patch is in.

hotel booking and rating page. having hotel reviews be applied for a 2 week window for logged in users is a good idea - quality of accommodation can change over time / seasons. So counting reviews on the same hotel should be aggregated for a specific window. for a new season another vote count as a new vote. that way you can have nice analysis over time. on the same site rating another users uploaded images shall be enforced to never change. different field, maybe even different voting widget so we should have different configuration for both. https://www.drupal.org/project/votingapi_widgets has an example implementation on this.

The patch in the 5th comment is just a workaround, if I'm not mistaken. If not, will this patch be merged anytime?

The latest patch does not work with beta1 release, so I repatched the 8.x-dev version.

Actually the patch does not work as desired, saving a vote by votingapi_widgets is causing an Exception:

Update existing 'vote' entity while changing the ID is not supported.

So I moved the logic to the Vote::preSave() method.

I only updated the target version of the issue, against which the patch #12 is applied.
The changes still need to be reviewed.

I seem to be struggling to get the patch from #12 to apply from the root of the votingapi folder. It's asking me what files to patch. Am I missing something in this?

*EDIT - you learn something new everyday.. adding in the -p1 to the patch command solved the issue.

patch -p1

I created a new issue with a different approach : https://www.drupal.org/project/votingapi/issues/3060468

Instead of using the Vote::preSave method to prevent double-voting, I use the VoteStorage::getUserVotes method, which not only prevent the double-voting, but also retrieves the correct votes for the current user (relative to its source and the rollover window you choose), so you don't end up displaying vote from another user.

I also added the "Immediately" and "Never" options like here, but also added a new config to choose between different sources (ip, cookie, or ip + cookie), so developers have more options to work with it.

I can see where @Andre-B is going above in #8 and it makes a certain amount of sense. Seeing as there has not been conscientious on this, here is a patch just to add the options like the title asks, allowing modules to use them how they like. This is needed especially since -1 is the default in the settings.

I just wanted to point out that the issue exists for Registered users in the Voting API settings too. There is no "Never" option there either, same as for anonymous users.

This issue has strayed pretty far from the original post. I don't think we're going to get anywhere unless we handle these issues separately. Bottom line is Voting API still has not been completely ported to D8.

There are three distinct issues here:

1. The "Anonymous vote rollover" and "Registered user vote rollover" settings do not have a "Never" option in D8. This is because SettingsForm was never completely ported to D8. SettingsForm also has wrong documentation, coding standards problems, and a bad constructor. All these things need to be fixed - the port to D8 needs to be completed, we can't move on to bigger and better things until the settings are handled correctly. These fixes don't need discussion, they just need to be committed. #20 does part of this, not all of it.
2. The "Anonymous vote rollover" and "Registered user vote rollover" settings DON'T DO ANYTHING. This is because the voting window functionality was not ported to D8. There are a variety of places and ways this can be done. #5 and #12 are both options, but not the only options. However, making this functionality work in D8 requires step 1) be completed first.
3. The voting window functionality could be improved. This is the subject of #8 and #18. But we don't even have the functionality ported to D8 and working in D8 yet, so patches to improve it are premature. I think we first need to make it work exactly the same as in D7 at this point so that people can transition their sites from D7 to D8. Once we have a working D8 release that implements this functionality we can work on improving it.

Attached is a patch for step 1). This step can be fixed now. Let's take this in steps and maybe we can finish porting this module to D8.

Patch still applies and tests still pass ...

Works fine for me too. Using with Rate 2.x-dev branch. The extra fixes seem also nice.