I generated a tags file for Drupal 8.x following the recipe in #1347302: Tags files are too big..
The tags file is large, and it includes many tags that are not useful. They can even get in the way. For example, having several tags for variables named $t makes it harder to find the one for t(). This deserves more thought, but for now I removed all tags for variables from drupal8.tags. I will add this file to the project without further review.
In D8, several files and subdirectories are placed under the core/ directory. This breaks the method our scripts use to find the root of the Drupal installation. I have attached a patch that fixes this. Because of path-separator issues, I tested it on Windows as well as on a Mac. So far, so good.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | drupal8-core-9.patch | 771 bytes | benjifisher |
| #7 | drupal8-core-7.patch | 573 bytes | benjifisher |
| #3 | drupal8-core-3.patch | 2.53 KB | benjifisher |
| drupal8-core.patch | 2.66 KB | benjifisher |
Comments
Comment #1
benjifisherI forgot to mark it "needs review."
Comment #2
benjifisherD'oh! I forgot to replace
/tmp/drupal-8.xwith$DRUPAL_ROOT.I just committed a corrected version of the tags file.
To make best use of the tags file for D8, you will need the patch at the top of this issue.
I guess I should not use "$DRUPAL_ROOT" in my commit messages. :-(
Comment #3
benjifisherSome recent commits conflict with the original patch, so here is a new one.
Comment #4
benjifisherI want this patch in place in time for Boston Drupal 8 patch party, so I have committed it: 9544df3. The patch in #3 applied cleanly.
Comment #5
benjifisherI forgot to mark it as fixed.
Comment #6
benjifisherDrupal 8 is a moving target!
The
s:DrupalRoot()function tries to guess what part of a path is the Drupal root directory. One of the things it looks for iscore/cron.php. That file seems to have been removed. (According to Git, it was back in May, 2012: d13fd18f1e2dbd02a2efba5786dfbaa6dbd58cca.) So now vim does not recognize the Drupal root for D8.Comment #7
benjifisherThe attached patch looks for
core/authorize.phpinstead ofcore/cron.php. Already committed: 39a6217.Comment #8
benjifisherIt does not work on Windows.
Comment #9
benjifisherThe problem is the path separator in
core/authorize.phpandcore/modulesetc. I changed the/to[\/]. While I was at it, I changed.to\.. See the attached patch.It is funny that I did not notice this problem earlier. :-(
Already committed: bd00bd2.