Problem/Motivation

Depreciated function warning

Deprecated function: Drupal\views_xml_backend\Plugin\views\query\Xml::ensureTable(): Implicitly marking parameter $join as nullable is deprecated, the explicit nullable type must be used instead in include() (line 576 of drupal11/vendor/composer/ClassLoader.php)

Steps to reproduce

Use PHP8.4 and use module in a view
Clear cache

Proposed resolution

In views_xml_backend/src/Plugin/views/query/Xml.php look for

public function ensureTable(..., JoinPluginBase $join = NULL)

and change it to:

public function ensureTable(..., ?JoinPluginBase $join = NULL)

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

aitala created an issue. See original summary.

garvitasakhrani made their first commit to this issue’s fork.

garvitasakhrani’s picture

Status: Active » Needs review

Fixed the PHP 8.4 deprecation warning by adding the nullable type declaration for the $join parameter.
Please review. Thanks!

aitala’s picture

That works.

Thanks,
E