The module have some coding standards and best practices issues.

CommentFileSizeAuthor
#7 Screenshot from 2024-07-12 16-05-35.png127.97 KBriddhi.addweb
#5 Screenshot 2023-01-25 at 17.45.45.png149.03 KB_pratik_
#2 coding-standards-and-3336329-2.patch696 bytesraghavendra a m

Issue fork views_table_rowspan-3336329

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Raghavendra A M created an issue. See original summary.

raghavendra a m’s picture

raghavendra a m commented
Status: Active » Needs review
Issue tags: -The module have some coding standards and best practices issues.
StatusFileSize
new coding-standards-and-3336329-2.patch696 bytes

Hi, Uploading patch for the fix.

dharmeshbarot’s picture

dharmeshbarot commented
Assigned: Unassigned » dharmeshbarot
Status: Needs review » Needs work

In the above patch #2, you just added one empty line and it doesn't work.

_pratik_ made their first commit to this issue’s fork.

_pratik_’s picture

_pratik_
Primary language English
Location Indore
commented
StatusFileSize
new Screenshot 2023-01-25 at 17.45.45.png149.03 KB

Hi @dharmeshbarot & @Raghavendra,
Found only one phpcs error. #2 will work for this.
thanks

dharmeshbarot’s picture

dharmeshbarot commented
Status: Needs work » Needs review
riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2024-07-12 16-05-35.png127.97 KB

- Moving this into Needs to work, because when the user applies the patch, then the patch is not applied. Attaching a screenshot for the same.