Here is a patch that rewrites the module in a few ways.

  • You are now only allowed to specify one menu. If you add anything in the menu selector box then it ignores the radio selection of the menu.
  • Hovering over the menu item will now pause the rotation as expected.
  • No need to add a link to the slideshow. It will automatically wrap the slideshow item with the menu link.
  • The slides need to be ordered in the order of the menu items. It will mark the activeSlideMenu in order.

Tell me how it works.

CommentFileSizeAuthor
#13 rewrite-646210-4.patch9.06 KBredndahead
#12 views_slideshow_menu.views_slideshow.inc_.rej_.txt3 KBShai
#12 views_slideshow.js_.rej_.txt3.77 KBShai
#8 rewrite-646210-3.patch12.52 KBredndahead
#2 rewrite-646210-2.patch12.53 KBredndahead
#1 rewrite-646210-1.patch12.52 KBredndahead

Comments

redndahead’s picture

redndahead commented
Status: Active » Needs review
StatusFileSize
new rewrite-646210-1.patch12.52 KB

Here is the patch. If this looks ok then it will become version 2.x.

redndahead’s picture

redndahead commented
StatusFileSize
new rewrite-646210-2.patch12.53 KB

Fix issue with hovering over menu links.

Shai’s picture

Shai commented

@redndahead,

Great to see the activity. I'm confused about whether the current dev version includes the two patches, or whether they should be applied to the current dev version, and if so is #2 inclusive of #1 or should they be applied separately,

Thanks much,

Shai

redndahead’s picture

redndahead commented

The patches have not been committed. Apply #2 and re save your views settings to see how it works.

Shai’s picture

Shai commented

@redndahead,

The patch did not apply. I got three hunk failures:

Shai$ patch < rewrite-646210-2.patch 
patching file views-slideshow-menu.tpl.php
patching file views_slideshow.css
patching file views_slideshow.js
Hunk #1 FAILED at 1.
Hunk #3 FAILED at 22.
Hunk #4 FAILED at 81.
3 out of 4 hunks FAILED -- saving rejects to file views_slideshow.js.rej
patching file views_slideshow_menu.info
patching file views_slideshow_menu.module
patching file views_slideshow_menu.theme.inc
patching file views_slideshow_menu.views_slideshow.inc
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 39.
Hunk #6 FAILED at 169.
3 out of 6 hunks FAILED -- saving rejects to file views_slideshow_menu.views_slideshow.inc.rej
Shai’s picture

Shai commented

@redndahead,

I want to try out your re-factored version... If I can't get the patch to apply, can you post or email me a zip version of the current version of the module?

Thanks,

Shai

redndahead’s picture

redndahead commented

Sorry I tried to run the patch and it didn't work either. I'll try and get something out soon.

redndahead’s picture

redndahead commented
StatusFileSize
new rewrite-646210-3.patch12.52 KB

And after a really long delay we have a 3rd try.

Shai’s picture

Shai commented

Great: I look forward to applying and testing on Monday.

Shai

Shai’s picture

Shai commented

:(

Patch didn't apply for me. Downloaded the dev version and then applied patch and got results below:

views_slideshow_menu Shai$ patch < rewrite-646210-3.patch 
patching file views-slideshow-menu.tpl.php
patching file views_slideshow.css
patching file views_slideshow.js
Hunk #1 FAILED at 1.
Hunk #3 FAILED at 22.
Hunk #4 FAILED at 81.
3 out of 4 hunks FAILED -- saving rejects to file views_slideshow.js.rej
patching file views_slideshow_menu.info
patching file views_slideshow_menu.module
patching file views_slideshow_menu.theme.inc
patching file views_slideshow_menu.views_slideshow.inc
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 39.
Hunk #6 FAILED at 169.
3 out of 6 hunks FAILED -- saving rejects to file views_slideshow_menu.views_slideshow.inc.rej
redndahead’s picture

redndahead commented

Can you attach those reject files.

Shai’s picture

Shai commented
StatusFileSize
new views_slideshow.js_.rej_.txt3.77 KB
new views_slideshow_menu.views_slideshow.inc_.rej_.txt3 KB

Here are the reject files.

redndahead’s picture

redndahead commented
StatusFileSize
new rewrite-646210-4.patch9.06 KB

Alright 4th time is a charm. I think I figured out the problem.

Shai’s picture

Shai commented

Applied cleanly, but it took down my site (no big deal, very easy to get back). Spinning ball and white screen.

I had been hesitating to write since I thought I should apply it to a totally fresh install and a fresh views slideshow. But I won't be able to do that for a couple days... So I thought I should just report my experience.

Shai

redndahead’s picture

redndahead commented

I would try it on a fresh install. there are some definite settings changes that may or may not contribute to that issue. Tell me what you get after trying on a fresh install.

Shai’s picture

Shai commented
Status: Needs review » Reviewed & tested by the community

Looks good. Worked fine on a fresh install. On my site where I actually need this... I'll try uninstalling views_slideshow and views_slideshow_menu and reinstall everything.

But don't wait on that for committing this. I think you should commit the most recent patch to dev without further delay. Then after some more testing maybe we can come out with a Version 2.0 and I'll make the screen cast.

Thanks much,

Shai

redndahead’s picture

redndahead commented
Status: Reviewed & tested by the community » Fixed

Alright it has been committed to the 2.x line. And a new dev release should be out within the next 12 hours.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.