The plugin checks values very optimistically, leading to tons of notices. The code responsible for checks and defaults is also needlessly complex.

CommentFileSizeAuthor
#2 views_ef_fieldset-sanitize-2710123-2.patch3.89 KBciss

Comments

ciss created an issue. See original summary.

ciss’s picture

ciss commented
Status: Active » Needs review
StatusFileSize
new views_ef_fieldset-sanitize-2710123-2.patch3.89 KB

Attached patch attempts to bring a bit more clarity to the code while doing more robust checks.

  • Pol committed c188c1e on 7.x-1.x authored by ciss 
    Issue #2710123 by ciss: Plugin does not properly sanitize values
pol’s picture

pol
the/that
Location Brussels
commented
Status: Needs review » Fixed

Thanks!

  • Pol committed c188c1e on 7.x-2.x authored by ciss 
    Issue #2710123 by ciss: Plugin does not properly sanitize values

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.