The attached patch reshuffles the view options a bit to make Token support optional. It allows the argument handling to be 'none' (allowing Views' normal argument default code to take over), 'nid/uid' (passing in the nid or uid of the object being displayed), or 'token' (equivalent to the current system).

It only shows token options when that mode is selected, and degrades gracefully when token isn't present. It's a bit cleaner and a bit more consistent and it means one less dependency for the "super simple" cases where someone just wants to stick something on the user profile.

CommentFileSizeAuthor
#1 views_attach_optional_token.patch14.23 KBeaton
views_attach_optional_token.patch14.23 KBeaton

Comments

eaton’s picture

eaton commented
StatusFileSize
new views_attach_optional_token.patch14.23 KB

After some careful thinking I changed the default options -- node content views now default to the 'nid' behavior and profiles default to the 'uid' behavior. Token is an option if token module is installed. This mirrors the 1.x behavior.

eabrand’s picture

eabrand commented
Status: Active » Needs review

I didn't have any problems with it. Seems like a great patch!

niklp’s picture

niklp commented

Subscribe, cos AFAICT the patch won't apply against dev.

eaton’s picture

eaton commented
Status: Needs review » Fixed

Committed with Crell's blessings to the dev branch. Will do some additional testing before the 2.1 release is rolled.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.