Hi,

I noticed the guid is generated using the url function, however this function returns a language dependent url, such as http://host/en/node/1234. The attached patch fixes this problem.

CommentFileSizeAuthor
#1 guid.patch1.13 KBguillaumev
language_dependent.patch859 bytesguillaumev

Comments

guillaumev’s picture

guillaumev commented
StatusFileSize
new guid.patch1.13 KB

I'm attaching another patch which adds a check to see if the item has not already been downloaded and if the GUID does not already exist in the database, in which case it returns the GUID of the downloaded node...

hefox’s picture

hefox commented

Seems good, will review and test it out.

Can anyone think of a suitation where that second check would not be desirable?

If so, should it be configurable?

hefox’s picture

hefox commented
Status: Needs review » Fixed

Hm, this is what was commited http://drupal.org/cvs?commit=472304

Due to the previous question , decided to make using feeds an optional setting for the style.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

guillaumev’s picture

guillaumev commented
Status: Closed (fixed) » Needs work

Hi,

Thanks for the fix but there is a small typo (I'm too lazy to make a patch for this). In views_atom.module, function views_atom_guid, you have 'use_existing_from_feeds' (note the s at the end), while in the rest of the module, you use 'use_existring_from_feed' (without an s at the end).

You just need to remove the s at the end of 'use_existing_from_feeds' in views_atom.module and it will work.

hefox’s picture

hefox commented
Status: Needs work » Fixed

ooooppppssssss

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.