Problem/Motivation

Due to bug in logic check, "Cache tags to exclude via regular expression" were never run unless "Cache tags to exclude" had a value set in it too.

Steps to reproduce

Install
Set regex exclude, but leave static exclude empty
Check tags on view to find regex exclude have not been excluded

Proposed resolution

Fix logic check which shortcuts running the excludes so that it checks both fields before returning without action.

Remaining tasks

  • ✅ File an issue
  • ➖ Addition/Change/Update/Fix
  • ➖ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Release notes snippet
  • ❌ Release

User interface changes

  • Regex exclude will now not silently fail if static exclude not set

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • @todo

Issue fork views_advanced_cache-3625822

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

elc created an issue. See original summary.

elc’s picture

elc commented
Title: Regex exclude did not fire unless static exclude present » Regex exclude not run in all configurations
Version: 3.x-dev » 2.x-dev
Status: Needs work » Patch (to be ported)

Update title.

Fixed for 3.x in #3582551: Deprecation of per-row tags and caching; D12 support.

Needs to be back-ported to 2.x.

elc opened merge request !21

  • elc committed 291fdc67 on 2.x 
    fix: #3625822 Regex exclude not run in all configurations.

By: elc

elc opened merge request !23

  • elc committed 0e07a2e1 on 2.x 
    task: #3625822 Additional phpstan/phpcs cleanup.

By: elc
elc’s picture

elc commented
Assigned: elc » Unassigned
Status: Patch (to be ported) » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.