Node revision link access

dereine, can you review this?

The question is what should happen if the user has no access to the revision. Shouldn't the link disappear totally?
This could be configurable.

The code looks fine beside

+      $node_access = (object)array(

(the missing space)

Current usage of the handler will brake. You should either convert the existing settings or create other options. Thanks

+      if (!_node_revision_access($node_access, 'view')) {
+		if (!empty($this->options['link_to_node_revision']['substitute'])) {
+		  $this->options['alter']['path'] = "node/" . $values->{$this->aliases['nid']};
+		}
+		else {
+		  $this->options['alter']['make_link'] = FALSE;
+		}
+      }

Please use spaces instead of tabs here.

The rest looks fine in general.

+    $form['link_to_node_revision']['#tree'] = TRUE;
     $form['link_to_node_revision'] = array(
       '#title' => t('Link this field to its node revision'),
       '#description' => t('This will override any other link you have set.'),
       '#type' => 'checkbox',
       '#default_value' => !empty($this->options['link_to_node_revision']),
     );

That can't work. I suspsect the #tree isn't need in the latest patch anyway?

+        if (!empty($this->options['link_to_node_revision_replace'])) {
+          $this->options['alter']['path'] = "node/" . $values->{$this->aliases['nid']};
+        } else {
+          $this->options['alter']['make_link'] = FALSE;
+        }

Should be

  }
  else {

Also, while it's not your code, but since you're patching this already and it needs to go back for one more reroll, can you fix the code style on this?

       $this->options['alter']['path'] = "node/" . $values->{$this->aliases['nid']} . '/revisions/' . $values->{$this->aliases['vid']} .'/view';

The . operator on the last bit should have spaces to either side. Not sure how I keep letting these little things slip through.

We could work a bit on the description

If you keep this checkbox unchecked and user has no access to revision link will not be shown.

What about

If you keep this checkbox unchecked and the current user has no access to the revision the link will be hidden.

The rest looks fine.

So.

Perhaps you could find a even better one.

Patch does not apply to 3.x branch.

NOte that this is a new feature and as such I am unlikely to commit it to 2.x, so let's redo this against 3.x only.

Thank you for this patch!

In the latest version of views instead of $values->{$this->aliases['nid']}
$nid = $this->get_value($values, 'nid'); is used, but everything seems to work as expected.

This is still the case in D7.

IMO root cause is Drupal core, which disables the page when only one revision exists. It should be dealt with there.
Tagging this as a duplicate of #808730: Show the Revisions tab/page even when only one revision exists.