views_handler_filter_float has no reason to exist. [#931886]

The docblock says:

/**
 * Simple filter to handle greater than/less than filters.
 * It based on views_handler_filter_numeric but deals with
 * float numbers.
 */

However, the functions it overrides (op_simple, op_between) are the same both in the parent and in this class.
This is a result of porting, since Views 6.x-3.x has different code in there, for example:

$this->query->add_where($this->options['group'], "$field >= %f", $this->value['min']);

So, we should kill this file and use views_handler_filter_numeric instead.
If no objections are raised, I'll provide a patch tonight.

Comment	File	Size	Author
#8	931886.patch	2.93 KB	bojanz
#7	931886.patch	3.13 KB	bojanz
#5	931886.patch	3.13 KB	bojanz

Comments

Comment #1

dawehner

German

commented 5 October 2010 at 08:54

The reason is that dbtng now handles the placeholders/escaping for us. Perhaps this should be documented because some people will use it.

Comment #2

bojanz commented 5 October 2010 at 08:59

Assigned:

Unassigned

» bojanz

We have an UPGRADING topic in advanced help (which we added when we killed hook_views_handlers()), I'll add a note there.

Comment #5

bojanz commented 5 October 2010 at 21:45

Status:

Active

» Needs review

Status	File	Size
new	931886.patch	3.13 KB

Here's a patch.

Comment #6

dawehner

German

commented 5 October 2010 at 21:50

 patch -p0 < 931886.patch
patching file handlers/views_handler_filter_float.inc
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file handlers/views_handler_filter_float.inc.rej
patching file help/api-upgrading.html
Hunk #1 FAILED at 1.
1 out of 2 hunks FAILED -- saving rejects to file help/api-upgrading.html.rej
patching file modules/field.views.inc