I'm using exposed filter of created date with "Is between" and optional. When the input fields are empty the list is too, although it's should be unfiltered list. I guess It's causing from the WHERE (node.created >= 0) AND (node.created <= 0) sentence. as far as I understand, this sentence should not be there at all while the fields are empty. attach a patch suggest to fix it.

CommentFileSizeAuthor
#12 views_filter_date_4.patch2.07 KBkonforti
#8 views_filter_date_3.patch2.21 KBkonforti
#3 views_filter_date_2.patch1.69 KBkonforti
#2 views_filter_date_1.patch1.43 KBkonforti
views_filter_date.patch843 byteskonforti

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review

update

konforti’s picture

konforti commented
StatusFileSize
new views_filter_date_1.patch1.43 KB

There was a problem handling dates from 1/1/1970 and earlier.
This patch handle it in a better way.

konforti’s picture

konforti commented
StatusFileSize
new views_filter_date_2.patch1.69 KB

When entering just one value in a two values exposed date filter, it returns no result (before the above patch or all result with the patch). some times you want to filter from some date on or from ever to some date. in this one added this fix which depending on the former code.

YK85’s picture

YK85 commented

is this related to #681450: Views optional exposed date filter does not work without value?

esmerel’s picture

esmerel commented

#843878: Optional "in between" filters not really optional may be related as well. I think they're expressing the same issue, but maybe in different places.

Bevan’s picture

Bevan commented

This ticket is about date filters for node dates that are supported in views, while #681450: Views optional exposed date filter does not work without value is about CCK Date fields, supported by date module. Though the bugs are very similar, the causes and fixes are entirely unrelated.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

In Views 3, we need to actually make sure that both of these statements are part of the same add_where() or we run the risk of the between becoming an OR. I realize that's a problem with the existing code but we may as well fix it as part of this patch.

Also, I don't understand why the intval() was split out. There seems to be no benefit to that change.

konforti’s picture

konforti commented
StatusFileSize
new views_filter_date_3.patch2.21 KB

Fixed to implement one add_where() for both statements.
The intval() split out, was made for getting the difference between, the timestamp 0 to FALSE.
The intval() returns 0 in both cases. The IF statements fixed, to make it actually work.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs work » Needs review

Remember to mark patch updates as 'needs review' or they don't get seen.

nicholas.alipaz’s picture

nicholas.alipaz commented

subscribing since I was affected in a duplicate issue.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

Hm. There is a conflict and the patch currently does not apply.

There's also some minor style issues that I was going to clean it manually, but since it doesn't apply I'll kick it back. This has some spacing stuff that I would like cleaned:

-
+

It's hard to see since the spaces are invisible, but that's changing a blank line to a line with spaces equal to the indent level of the previous line. Most modern editors can auto-trim trailing spaces for you.

+    }
   }
-
   function op_simple($field) {

Removing the blank link prior to a function is against my coding style.

konforti’s picture

konforti commented
Status: Needs work » Needs review
StatusFileSize
new views_filter_date_4.patch2.07 KB

Oops, sorry.
Re-created the patch with the fixes.
Tested for no conflict on applying.
Thanks.

PixelClever’s picture

PixelClever commented
mustanggb’s picture

mustanggb commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)