The current name of this filter is counter-intuitive because "Node: Moderate Yes" seems to imply that the node has been moderated, but really means that the node needs to be moderated. I think it makes more sense to say "Node: In moderation Yes".

Comments

EvanDonovan’s picture

I think this would make the interface clearer. I may write a patch soon.

joachim’s picture

Category: feature » bug

+1

It's really unclear what this filter does -- does it mean the node is potentially moderated, or is currently not pending approval.

I think "Node: In moderation queue" would be the clearest way to put it.

Calling this a bug because I had to go read the code of modr8 module to understand what this would do.

joachim’s picture

Title: "Node: Moderate" filter should be called "Node: In moderation" » node and comment moderation UI texts are unclear
Status: Active » Needs review
StatusFileSize
new2.32 KB

Patch!

I am combining this with #656416: Comment: In moderation filter terminology mismatch since they both cover moderation filters -- we should get the text consistent in both cases.

This still has a Yes/No option but the label makes it clear what you are saying Yes/No to :)

(Related issue: sort orders are need work too: see #811268: booleans don't make human sense with views_handler_sort.)

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

This helps to undestand it a lot.(its a bug :) )

EvanDonovan’s picture

Thanks, joachim, and dereine for the RTBC. I really like the new texts.

merlinofchaos’s picture

Version: 6.x-2.6 » 7.x-3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 6.x branches. Doesn't seem to apply to 7.x, probably something trivial.

dawehner’s picture

Status: Patch (to be ported) » Fixed

yeah. Comments table got renamed to comment.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.