todo: default sorting of views tables

Hmm. I think this should be a per field setting, not a global setting. I don't think a global setting is all that useful.

@dereine: Here is an example of settings applied per field #383994: Column align

wasn't too hard to implement looking at both patches

surprised nobody else go to it before me (that I know of)

a better patch would check if fields are numeric (desc) or alphanumeric (asc) a set a default automatically
but this is good enough for me

Derek

oops made a mistake heres the right one

I'd suggest removing the old default sort option at the bottom as its no longer needed

The above patch had a couple of code style issues, plus it failed to add extra columns in the table where the column was not available. Plus, we should use dependency checking to make the default sort order field not visible if sorting is not enabled (since it is pointless).

Looks good and works as it should.

Edit: I think I was mistaken about this. Testing further.

Setting back to NR based on edit in #10

I did not see this patch and I modified a views module on a site to have this option.
The patch looks almost identical to what I did with 2 exceptions.

+++ plugins/views_plugin_style_table.inc
@@ -51,12 +51,14 @@ class views_plugin_style_table extends views_plugin_style {
-      $this->order = !empty($this->options['order']) ? $this->options['order'] : 'asc';
+      $default_sort = !empty($this->options['info'][$sort]['default_sort_order']) ?  $this->options['info'][$sort]['default_sort_order'] : 'asc';
+      $this->order = !empty($this->options['order']) ? $this->options['order'] : $default_sort;

This is not needed.

+++ plugins/views_plugin_style_table.inc
@@ -51,12 +51,14 @@ class views_plugin_style_table extends views_plugin_style {
-      $this->order = !empty($_GET['sort']) ? strtolower($_GET['sort']) : 'asc';
+      $default_sort = !empty($this->options['info'][$sort]['default_sort_order']) ?  $this->options['info'][$sort]['default_sort_order'] : 'asc';
+      $this->order = !empty($_GET['sort']) ? strtolower($_GET['sort']) : $default_sort;

Same as above.

I say the default order should be left as is.
Even better, the default order options should be removed and just leave the radios for the default column to sort on.

Powered by Dreditor.

dereine: Can you reroll based on #12?

+++ plugins/views_plugin_style_table.inc
@@ -201,6 +203,14 @@ class views_plugin_style_table extends views_plugin_style {
+          '#options' => array('asc' => t('Up'), 'desc' => t('Down')),

The text should be consistent with the default sort order (Ascending/Descending)

The patch seems to be for Views 6.3. I manually applied it to 6.2 and it works as expected.
If I have enough time tomorrow I will make a test site and install Views 6.3 and try on that too (just to be sure, I don't expect surprises on that version).

Beside the small issue above seems RTBC to me.

For convenience here is the patch resulted from the 6.2 branch.

Powered by Dreditor.

To me it was confusing at first and consistency is always better.

Here is the patch for 6.3 with the changed text. merlinofchaos can decide which one he prefers.

Since this is a new feature, I have elected to place this only in Views 3. Committed to D6 and D7.