I would like an onClick field added to the Rewrite Field Section of the views UI. This will be used for adding tracking code e.g. PIWIK trackGoal() to fields used as links.

CommentFileSizeAuthor
#15 views_handler_field.inc_.patch1.87 KBscott.thomas
#3 onClick-2415327-2.patch1.8 KBscott.thomas
#1 onClick-2415327-1.patch3.49 KBscott.thomas

Comments

scott.thomas’s picture

scott.thomas commented
StatusFileSize
new onClick-2415327-1.patch3.49 KB
scott.thomas’s picture

scott.thomas commented
Title: Add onClick field to » Add onClick field to views_handler_field.inc
scott.thomas’s picture

scott.thomas commented
StatusFileSize
new onClick-2415327-2.patch1.8 KB

Cleaner Patch

scott.thomas’s picture

scott.thomas commented
Status: Active » Needs review

The last submitted patch, 1: onClick-2415327-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: onClick-2415327-2.patch, failed testing.

scott.thomas’s picture

scott.thomas commented
Version: 7.x-3.8 » 7.x-3.10

Status: Needs work » Needs review

scott.thomas queued 3: onClick-2415327-2.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: onClick-2415327-2.patch, failed testing.

scott.thomas’s picture

scott.thomas commented
Component: Views Data » Code

Status: Needs work » Needs review

scott.thomas queued 3: onClick-2415327-2.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: onClick-2415327-2.patch, failed testing.

scott.thomas’s picture

scott.thomas commented
Version: 7.x-3.10 » 7.x-3.x-dev
Component: Code » Miscellaneous

Status: Needs work » Needs review

scott.thomas queued 3: onClick-2415327-2.patch for re-testing.

scott.thomas’s picture

scott.thomas commented
StatusFileSize
new views_handler_field.inc_.patch1.87 KB
scott.thomas’s picture

scott.thomas commented
scott.thomas’s picture

scott.thomas commented

I have re read the guidelines for submitting patches and I can see that I did not follow the process exactly. Would you like for me to start over and submit another file?

Thanks, Scott

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Closed (won't fix)

Thank you for providing a patch.

I'm sorry but I really think this is a feature we don't want to support.
If you want to have behaviour, I'd recommend custom javascript in a file.

Just had a look on piwik trackgoal, see http://developer.piwik.org/api-reference/tracking-javascript ... its is a javascript method you can trigger also from custom code.

So yeah please use the best practise of an actual external file