Missing plural in new comments mark [#206934]

In modules/views_comment.inc, line 250:
$comments .= l(t('@num new', array('@num' => $new)), "node/$data->nid", NULL, NULL, 'new');
should be:
$comments .= l(format_plural($new, '1 new', '@count new'), "node/$data->nid", NULL, NULL, 'new');

In Italian it's different! E.g.: 1 new = 1 nuovo; 2 new = 2 nuovi!

From the api documentation:
Please make sure it is clear this is singular, to ease translation (e.g. use "1 new comment" instead of "1 new"). Do not use @count in the singular string.

Comment	File	Size	Author
#1	views_new_comments_plurals.patch	571 bytes	neochief

Comments

Comment #1

neochief commented 23 February 2008 at 12:50

Priority:	Minor	» Normal
Status:	Active	» Needs review

Status	File	Size
new	views_new_comments_plurals.patch	571 bytes

subscribing too
for Russian is the same trouble. I've prepared the patch to fix this

Comment #2

magnus commented 11 March 2010 at 15:23

Version:	5.x-1.6	» 6.x-2.x-dev
Component:	Code	» comment data
Status:	Needs review	» Active

This is still a issue in 6.x and the function is very different from 1.6 so I haven't been abled to use this patch. I think the handler for this functions lies within modules/comment/views_handler_field_node_new_comments.inc, but I haven't been abled to make any progress to fix this.

This issue could be handled through #317653.