If you manually add a new display via the UI you get page_1 as display id, though if you just use the wizard you get 'page'.

To be able to fix the issue we should first talk about the actual expected behavior.

CommentFileSizeAuthor
#11 1793700-11.patch21.97 KBdamiankloip
#8 1793700-8.patch17.7 KBdamiankloip
#7 1793700-7.patch13.7 KBdamiankloip
#5 1793700-5.patch11.43 KBdamiankloip
#2 1793700-wizard-display-ids.patch3.97 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Assigned: Unassigned » damiankloip

We talked about this on IRC and decided we would like to suffix all displays, so the wizard display creation should start with e.g. 'page_1' and not 'page'.

I will change this, and the tests.

damiankloip’s picture

damiankloip commented
Assigned: damiankloip » Unassigned
StatusFileSize
new 1793700-wizard-display-ids.patch3.97 KB

Lets see how this gets on.

damiankloip’s picture

damiankloip commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1793700-wizard-display-ids.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 1793700-5.patch11.43 KB

Status: Needs review » Needs work

The last submitted patch, 1793700-5.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 1793700-7.patch13.7 KB

This one should pass now, he says....

damiankloip’s picture

damiankloip commented
StatusFileSize
new 1793700-8.patch17.7 KB

Removed todos and updated display ids on default views.

damiankloip’s picture

damiankloip commented
Title: The wizard creates "page" as first display id even the views UI itself creates page_1 » The wizard creates "page" as first display id even though the views UI itself creates page_1

Status: Needs review » Needs work

The last submitted patch, 1793700-8.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 1793700-11.patch21.97 KB

Now?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/lib/Drupal/views/Tests/UI/DisplayTest.phpundefined
@@ -85,7 +85,6 @@ class DisplayTest extends UITestBase {
-    // @todo Revising this after http://drupal.org/node/1793700 got in.

I should have known, that AFTER was wrong here.

In theory RTBC, from my perspective.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

#11: 1793700-11.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Committed
http://drupalcode.org/project/views.git/commit/393facd

Automatically closed -- issue fixed for 2 weeks with no activity.