In general the goal is to replace ctools functionality to be able to remove the dependency.
So this issue will be about removing the #dependency and replacing it with #states.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 1595022-depedency-states-6.patch | 84.44 KB | dawehner |
| #3 | 1595022-depedency-states-3.patch | 84.57 KB | dawehner |
| #2 | 1595022-depedency-states-2.patch | 64.49 KB | dawehner |
| #1 | 1595022-depdency-states.patch | 44.28 KB | dawehner |
Comments
Comment #1
dawehnerHere is some ongoing work.
Note: Some of them are converted, some of the are converted, but still has commented out #depedency. These are the ones which don't work at the moment.
Comment #2
dawehnerSome more work. Especially #1149078: States API doesn't work with multiple select fields would be helpful to solve a lot of the remaining issues.
Comment #3
dawehnerOkay finally got it working for all cases beside the preview settings under admin/structure/views/settings
Comment #4
dawehnerRemove this todo, this is intended as the operator identifier is an advanced settings which belongs into the fieldset.
This additional array is not required here.
Comment #5
tim.plunkettTagging.
Comment #6
dawehnerJust fixes the two mentions in #4
Comment #7
bojanz commentedI remember us nearly managing to convert Views to #states in the D7-port era :)
Big and boring-to-do patch. Good job.
Comment #8
tim.plunkettAbsolutely incredible. I tested a couple of the noticeably complicated parts (replacement patterns, mostly) and read through the whole patch. Looks damn good!
The tests won't pass for now, and they don't really test this anyway.
Comment #9
dawehnerThanks for testing!
It seems to make sense to write change notes about that, so people will know that they better should convert it.
Comment #10
tim.plunkettDoes that mean you committed this already? It seems you didn't push.
Comment #11
dawehnerI rechecked and at least now it should be pushed.
Comment #12
bojanz commentedComment #14
xjmSetting back to active for the change notice :)
Comment #15
tim.plunkettI added http://drupal.org/node/1736972