Field language conditions are missing in the query [#1438986]

Looks like the field language conditions vanished as of #1089876: Move field_language to display settings.

The mentioned issue moved the field language settings from the query to the display plugin. Unfortunately the field module wasn't adjusted accordingly. There you'll still find:

 if (field_is_translatable($entity_type, $field) && !empty($this->query->options['field_language_add_to_query'])) {

dereine already created a patch to fix this: http://paste.pocoo.org/show/550380/

I've just added another part to the patch to allow empty field values.

Comment	File	Size	Author
#3	views-field-language-conditions-are-missing-in-the-query-1438986-3.patch	2.26 KB	das-peter
	views-field-language-conditions-are-missing-in-the-query.patch	1.9 KB	das-peter

Comments

Comment #1

das-peter commented 13 February 2012 at 19:45

I just thought about the locale_field_language_fallback setting.
If the setting is enabled locale_field_language_alter() uses locale_field_language_fallback() to find the most appropriate language for the field content.
This is done by iterating over the language list returned by language_fallback_get_candidates() which returns the first matching value.

Currently I just assume that SQL will also return the value of the first matching language in the fallback list - if this correct, the patch could look like this: http://drupalbin.com/20809