If you create a new view which has node revisions as base table you get the node row plugin by default, though you can't select something else then fields.

CommentFileSizeAuthor
#12 views-1321364-12.patch855 bytestim.plunkett
#10 views-1321364-10.patch853 bytesjim0203
#7 views-1321364-7.patch891 bytesjim0203
#6 views-1321364-6.patch939 bytesjim0203
#3 revision-wizard-defaults-1321364-3.patch820 bytesrvilar

Comments

dawehner’s picture

dawehner
Primary language German
commented

The correct behaviour is to not select the node row plugin by default.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Novice

Fixing this sounds like a good task.

The fix would probably have to be in views_ui_node_revision_views_wizard.class

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
commented
Assigned: Unassigned » rvilar
Status: Active » Needs review
StatusFileSize
new revision-wizard-defaults-1321364-3.patch820 bytes

Attached is a patch that solves this

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work

Hm, I think this is just tweaking the node row plugin, not deselecting it.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented 
+++ b/plugins/views_wizard/views_ui_node_revision_views_wizard.class.phpundefined
@@ -9,6 +9,13 @@
+  ¶

If you replace this trailing whitespace with a docblock, I think this is right after all.

I'll open up a followup for a smarter row_style_options() by default, but this is all that can be done for now.

jim0203’s picture

jim0203 commented
StatusFileSize
new views-1321364-6.patch939 bytes

Re-rolling patch

jim0203’s picture

jim0203 commented
StatusFileSize
new views-1321364-7.patch891 bytes

Re-rolling patch properly, please ignore #6

jim0203’s picture

jim0203 commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, views-1321364-7.patch, failed testing.

jim0203’s picture

jim0203 commented
StatusFileSize
new views-1321364-10.patch853 bytes

Third time lucky ...

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review

Testbot!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new views-1321364-12.patch855 bytes

Fixed a minor indentation issue on the docblock. No commit credit for me.

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

Thanks for effort on this patch.

Committed this to 7.x-3.x and 8.x-3.x

Automatically closed -- issue fixed for 2 weeks with no activity.