In admin.inc, both views_ui_preview() and views_ui_edit_form() call set_display, but do not check to see if it returns FALSE.

I came across because the second conditional in view::build() wasn't working properly. The display handler is NULL, yet it continues to build.

CommentFileSizeAuthor
#1 1222494-admin-set_display-check.patch998 bytesdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1222494-admin-set_display-check.patch998 bytes

I'm wondering about a proper help message which should be used here?

Something like t('Invalid display id @display ?

Anyway here is a patch.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Commited this patch, there might be other places but better have something then nothing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.