views_menu_alter fails sometimes; views_cache_get() issue in _views_discover_default_views()

Been thinking about this... almost all of my views are in code; thus I think the loading views from code might not work 100% if the cache is being flushed at that instant.
views_get_applicable_views() calls views_get_all_views(). The list of views get loaded via view::load_views() and by views_discover_default_views(). views_discover_default_views() appears to load views in code.

views/includes/cache.inc gets loaded; so the _views_discover_default_views function is available. In here views_cache_get('views_default_views_index', TRUE) is called. Once the views index is grabbed, it then grabs each view from the cache. Right here we have a problem. We could grab the index but 1/2 though grabbing the views from the cache; the cache could be erased. That means the rest of the views do not get loaded.

Lets say views_cache_get is now returning FALSE for the 1/2 half of your views in code. Now that means none of the missing views from the cache will be loaded into the menu router. What's needed is a fallback for this condition.

  $data = views_cache_get('views_default:' . $view_name, TRUE);
  if (isset($data->data) && is_object($data->data)) {
    $cache[$view_name] = $data->data;
  } 

Seems like if one of the views that was in the index is missing assume cache is bad you must rely on code to get all the views.

Now that I've figured this out; patch to come soon.

Found it #853864: views_get_default_view() - race conditions and memory usage