Problem/Motivation

Currently, when changing settings and on some other occasions, the "VidstackPlayer" object is undefined leading to the error:

Vidstack Player JS library could not be loaded.

This could be a problem of the cdn, we should fix #3519303: Find a way to require vidstack library without CDN usage first (use a local library) and see if it is still a problem afterward.

Steps to reproduce

Change the formatter settings.

Proposed resolution

Fix the problem.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork vidstack_player-3519538

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 1.x Comparechanges, plain diff MR !9
About issue forks

Comments

grevil created an issue. See original summary.

grevil’s picture

grevil commented
Related issues: +#3519303: Find a way to require vidstack library without CDN usage

jan kellermann made their first commit to this issue’s fork.

jan kellermann’s picture

jan kellermann commented
Version: » 1.x-dev

I just added some code in this issue fork but startet no merge request:
https://git.drupalcode.org/issue/vidstack_player-3519538/-/compare/1.x.....

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3521502: Add support for Javascript with type "module"

Thanks @jan kellermann I guess this is for #3521502: Add support for Javascript with type "module"

jan kellermann’s picture

jan kellermann commented

No, this is to solve your problem of late loading / race conditions between scripts :)

anybody opened merge request !9

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » anybody
Priority: Major » Normal
Status: Active » Needs review

Sorry for being late ... ;D

Busy days and we were not touching this in the last months. On it now!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » Unassigned
Status: Needs review » Reviewed & tested by the community

GREAT WORK @jan kellermann! I guess you already had experience with this pattern? Any further things we should take care of here?

Thank you so much! I'll merge this now and tag a new release.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.