Problem/Motivation

As the title says.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork videojs-3619966

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

grevil opened merge request !37

grevil’s picture

grevil commented
Status: Active » Needs review

Should be good to go! Please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Needs review » Needs work

@grevil nice work! I think we should add some tests to ensure:

  1. the global library is present
  2. the component specific library is present
  3. both are not present if it's just a trigger thumbnail

Anything I missed?

PS: Tests are failing currently.

The other comments are just about naming and comments. Please merge once green. LGTM.

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

All green! Let's get things done and tag an alpha release!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

  • grevil committed b88072d2 on 10.x 
    fix: #3619966 Unify "getLibrary()", "getRemoteLibraries" and "...
grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Reviewed & tested by the community » Fixed

Merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.