On http://192.168.44.44/ default page you have some useful configured sites and development tools.

I think is worth to add some nice clean theme to it. Twitter Bootstrap seems to be good start point.

http://getbootstrap.com/

CommentFileSizeAuthor
#3 vdd-add_bootstrap_theme-2349915-3.patch8.59 KBcuteapoot
#1 add_bootstrap_theme_to-2349915-1.patch7.82 KBcuteapoot
current-welcome-page.png85.78 KBsobi3ch

Comments

cuteapoot’s picture

cuteapoot commented
Status: Active » Needs review
StatusFileSize
new add_bootstrap_theme_to-2349915-1.patch7.82 KB

I wish I had seen this earlier! I actually have a patch for this. Let me attach it.

Note: it also removes some of the anchor links, and opens the "hosts" link in the same window by default (because forcing users to open stuff in a new window drives me crazy).

ericrdb’s picture

ericrdb commented
Status: Needs review » Needs work
Related issues: +#2236323: Slick index.html page

Yes! It's been quite some time since I looked at this...

#2236323: Slick index.html page

Thanks for taking a stab at it, I'm eager to check out your work. With the recent commits, looks like this patch needs to be re-rolled.

cuteapoot’s picture

cuteapoot commented
Status: Needs work » Needs review
StatusFileSize
new vdd-add_bootstrap_theme-2349915-3.patch8.59 KB

I'm so happy that the vagrant-hostsupdater plugin got committed, because that makes my patch so much easier to implement (it would have caused merge conflicts otherwise).

The only issue I see with my code is that it uses the Bootstrap CDN, which might cause problems for someone working offline who doesn't have that code cached. Seems relatively minor, but worth discussing.

ericrdb’s picture

ericrdb commented
Status: Needs review » Needs work

Excellent, thanks for the patch and this layout is nicer on the eyes for sure.

Before committing, I do appreciate your concern about the CDN-based css files. Any objections to removing that dependency by creating local css files and referencing the local version from within index.html? I like removing that (minor?) potential failure point and don't yet see a downside for doing so.

Also, the help text for git cloning Drupal 8 needs updating because the branch name changed:

vagrant guest$ git clone --branch 8.0.x http://git.drupal.org/project/drupal.git .
ericrdb’s picture

ericrdb commented

One more item: how about removing lines 98-107, the commented out section?

    <!-- <h3>Questions</h3>
    <ul>
      <li><a href="#q1">Where can I find help?</a></li>
      <li><a href="#q2">How to ssh into virtual machine?</a></li>
      <li><a href="#q3">How to install fresh Drupal 8 version?</a></li>
      <li><a href="#q4">How to quickly install Drupal 7?</a></li>
      <li><a href="#q5">What is Webgrind and how would I use it?</a></li>
    </ul>

    <h3>Answers</h3> -->

That should keep the html code cleaner, yes? It's always there in git if we ever need the history of that file.

cuteapoot’s picture

cuteapoot commented

I can't believe I missed this nine months ago! I think your suggestions are perfect, but I'm not sure how to include those CSS/JS files. I tried modifying chef/cookbooks/core/vdd/recipes/vdd_help.rb to copy those files from chef/cookbooks/core/vdd/templates/default, but I got syntax errors. I don't know if I'm doing Ruby wrong or if I'm doing Vagrant wrong.