Problem/Motivation

Found that these two variants of bootstrap buttons are missing from the style guide.

Proposed resolution

Add Bootstrap buttons (Light,Dark)

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.7, varbase_styleguide-9.0.5

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

Before the fix:
Before the fix of Bootstrap buttons (Light,Dark)
After the fix:
After the fix of Bootstrap buttons (Light,Dark)

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

CommentFileSizeAuthor
#7 After-the-fix--Style guide _ dev varbase90x1varbase_styleguide1.png136.79 KBrajab natshah
#7 before-the-fix--Style-guide_varbase90x1.png122.3 KBrajab natshah
#3 3285361-3.patch659 bytesmutasim al-shoura

Comments

Mu'tasim Al-Shoura created an issue. See original summary.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
mutasim al-shoura’s picture

mutasim al-shoura commented
Assigned: mutasim al-shoura » Unassigned
Status: Active » Needs review
StatusFileSize
new 3285361-3.patch659 bytes

I applied this patch and the buttons were added successfully.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Issue tags: +varbase-9.0.7, +varbase_styleguide-9.0.5
StatusFileSize
new before-the-fix--Style-guide_varbase90x1.png122.3 KB
new After-the-fix--Style guide _ dev varbase90x1varbase_styleguide1.png136.79 KB
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released varbase_styleguide-9.0.5

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released varbase-9.0.7