Problem/Motivation

This recipe installs canvas_icon_picker and requires drupal/canvas_icon_picker: ~1.0.3. That was the first home for it, but it is the wrong one for two reasons:

  • The other Varbase site templates (Educare, Horizon Aid, RightUp) do not include Varbase Starter, so they get nothing. Every one of them would have to repeat the same declaration.
  • The picker is not specific to Starter. It is an editing-experience module that belongs with the rest of the admin experience.

Varbase Admin Base is taking it over in #3620064: it already installs ui_icons, which the picker builds on, and every site template already applies it, so one declaration covers all four.

Varbase Starter applies varbase_admin_base, so it keeps the picker either way. Left as is, the module would simply be declared twice.

Steps to reproduce

  1. grep -n canvas_icon_picker recipe.yml composer.json in this recipe: it appears in the install: list and in require.
  2. grep -rn canvas_icon_picker in varbase_admin_base: after #3620064 it appears there too.

Proposed resolution

Once #3620064 has landed and been released:

  • Remove - canvas_icon_picker from the install: list in recipe.yml.
  • Remove "drupal/canvas_icon_picker": "~1.0.3" from composer.json.
  • Bump the drupal/varbase_admin_base constraint to the release that carries it, so the dependency is still guaranteed.

Order matters. Do not remove it here before the Admin Base release exists, or Varbase Starter loses the picker in the gap.

Note that Varbase Starter does not currently set canvas_icon_picker.settings:allowed_packs at all, so the module installs with its default empty map and every discovered pack is offered. Admin Base sets the two packs the Vartheme BS5 themes ship, which is a small improvement Starter inherits for free.

This issue does not cover the Vartheme BS5 theme conversion (x-canvas-icon on the icon props) or re-exporting the Varbase Starter Canvas component configs. Those are separate, and the equivalent work for Educare and Horizon Aid is tracked on those projects.

What was verified

  • Two fresh Varbase 11 builds, Educare and Horizon Aid, with the declaration removed from this recipe and added to Varbase Admin Base 1.0.0-rc1: both install green and canvas_icon_picker is enabled on both, from Admin Base alone.
  • canvas_icon_picker.settings:allowed_packs reads back as bootstrap_icons, vartheme_social on both.
  • Zero log entries at Error or worse on either site.

Drafted with AI assistance (AI-Generated: Yes), per the Drupal AI policy. Every claim above was verified by running it.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • None. The module is still installed on a Varbase Starter site, from Varbase Admin Base instead of from here.

API changes

  • N/A

Data model changes

  • None. The same module is installed and the same config object exists; only the recipe that declares it changes.

Release notes snippet

  • The Canvas Icon Picker is now installed by Varbase Admin Base rather than by Varbase Starter, so every Varbase site template inherits it. No change for an existing Varbase Starter site.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue.