Problem/Motivation
This recipe models content. It also installs canvas_override and requires drupal/canvas_override, which is Drupal Canvas plumbing rather than content structure, and it is the only Varbase recipe that carries it.
The new Varbase Canvas Base recipe now owns the Drupal Canvas module installs (#3620177, merged, 1.0.x-dev released), so the declaration here is a duplicate.
Steps to reproduce
- Read
recipe.yml:canvas_overrideis in theinstall:list. - Read
composer.json:"drupal/canvas_override": "1.0.x-dev"is inrequire. - Neither is content configuration, and no other
varbase_*_baserecipe declares a Canvas module.
Proposed resolution
Remove the canvas_override entry from install: and the drupal/canvas_override requirement from composer.json. Nothing else changes.
The permission grants stay here. All 17 Drupal Canvas grants (create / edit / delete canvas_page, publish auto-saves, administer folders, administer patterns, administer components, administer content templates, administer page template, edit canvas global regions) are untouched, on all of content_editor, content_admin, seo_admin and site_admin. A Canvas page is content and these are content roles, so the grants belong with the roles.
That is deliberate and it matters: Educare, Horizon Aid and RightUp apply this recipe directly, not through Varbase Starter, and they do not require Varbase Canvas Base. Each carries 58-80 canvas.component / canvas.content_template config keys. Moving the grants out would have stripped their editors' Canvas permissions. An earlier revision of #3620177 did move them and was reverted for exactly this reason.
Ordering. Land Varbase Starter applying Varbase Canvas Base first, or both together. If this lands alone, a fresh Varbase Starter build installs no canvas_override until Starter catches up.
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ❌ Update Release Notes
- ❌ Release
User interface changes
- None. The same modules end up installed and the same roles hold the same permissions.
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- The
canvas_overrideinstall and itsdrupal/canvas_overriderequirement moved to the Varbase Canvas Base recipe. The Drupal Canvas permission grants are unchanged.
AI-Generated: Yes
Issue fork varbase_content_base-3620192
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rajab natshahComment #5
rajab natshah