Problem/Motivation

The Varbase Auth hooks already live in Drupal\varbase_auth\Hook\VarbaseAuthHooks, but varbase_auth.module and includes/helpers.inc still keep #[LegacyHook] / procedural backward-compat shims that delegate to that class. For Drupal ~11.4.0 these standard hooks are invoked by core only, so the shims are redundant.

Proposed resolution

Remove the #[LegacyHook] shim in varbase_auth.module and the legacy wrapper in includes/helpers.inc, and delete both files. All logic already lives in VarbaseAuthHooks (preprocessPage() and addTemplateVariable()).

Remaining tasks

API changes

The @internal legacy wrapper functions are removed; the logic remains available on the VarbaseAuthHooks service.

Release notes snippet

  • task: #3608370 Remove the #[LegacyHook] shims and procedural files for full OOP hooks
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rajab natshah created an issue. See original summary.

  • rajab natshah committed c3156b3d on 10.1.x
    task: #3608370 Remove the #[LegacyHook] shims and procedural files for...

  • rajab natshah committed 2d9cd8a5 on 9.2.x
    task: #3608370 Remove the #[LegacyHook] shims and procedural files for...
rajab natshah’s picture

Issue summary: View changes
Status: Active » Fixed
Issue tags: +varbase-9.2.0, +varbase_auth-9.2.0

✅ Released varbase_auth-9.2.0

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.2.0

rajab natshah’s picture

Version: 10.1.x-dev » 9.2.x-dev
rajab natshah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.