Problem/Motivation

The recipe hardcodes the Gin Login logo to a file inside vartheme_bs5, a theme that is not installed on a site built from any other site template.

In recipe.yml:

gin_login.settings:
  simpleConfigUpdate:
    logo:
      use_default: false
      path: themes/contrib/vartheme_bs5/logo.svg
    brand_image:
      use_default: true

On a site installed from a site template that ships its own theme, vartheme_bs5 is absent from core.extension. Read from such a site:

drush cget core.extension theme
'core.extension:theme':
  claro: 0
  gin: 0
  canvas_stark: 0
  easy_email_theme: 0
  vartheme_bs5_rightup: 0

So the admin login page is branded with a base theme the site does not use. The path may still resolve, because the file can be present on disk as a Composer dependency, but it is the wrong theme's artwork, and it silently overrides the branding of whichever theme the site actually runs.

This is not the site template's to fix: the template's own recipe never writes gin_login.settings. drupal_cms_admin_ui also writes that config object, but only brand_image, not the logo path.

Steps to reproduce

  1. Install Varbase 11 with a site template that ships its own front-end theme, for example RightUp:
    drush site:install varbase installer_site_template_form.add_ons=rightup --yes
  2. Confirm vartheme_bs5 is not an installed theme: drush cget core.extension theme
  3. Read the Gin Login setting: drush cget gin_login.settings
  4. It points at themes/contrib/vartheme_bs5/logo.svg.

Proposed resolution

Do not hardcode a specific theme's file. Either leave logo.use_default true so Gin Login follows the active admin or default theme, or resolve the path from the installed theme rather than naming vartheme_bs5 literally.

Remaining tasks

  • ✅ File an issue
  • ❌ Addition/Change/Update/Fix
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support
  • ➖ User Guide Documentation support
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Reviewed by a human
  • ❌ Code review by maintainers
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes
  • ❌ Release

User interface changes

  • The admin login page shows the branding of the theme the site actually uses, instead of the Vartheme BS5 logo.

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • The Gin Login logo is no longer hardcoded to the Vartheme BS5 theme, so sites built from other site templates keep their own branding on the admin login page.

Comments

rajab natshah created an issue.