Problem/Motivation

The content report table does not fit the admin theme. In Gin at 1440 pixels wide, the Content, "Found in" and Message columns wrap one or two words to a line, and Gin's sticky header shows a copy of the header row over the first row. "Found in" also repeats the title for content that is not a component.

Steps to reproduce

  1. Use Gin as the admin theme, and save some content with Vale findings.
  2. Open Reports, Prose linting, in a window 1440 pixels wide.
  3. The columns wrap word by word, a second header row covers the first row, and each row shows the title twice.

Proposed resolution

  • Remove the table caption, which only repeats the page title and pushes Gin's sticky header out of line.
  • Show "Found in" as a second line under the content link, for components only.
  • Drop the Bundle column. It stays a filter and stays in the CSV export.
  • Add a post-update that replaces the view on sites that have not changed it since 1.0.1. A site that has changed it keeps its view, and the update says how to get the new one.

Remaining tasks

Review.

User interface changes

The content report table goes from 10 columns to 8, with "Found in" under the content link for components.

API changes

None.

Data model changes

The views.view.vale_findings view changes, and a post-update applies it to sites that have not changed it.

Issue fork vale-3638432

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

deciphered created an issue. See original summary.

  • deciphered committed 68626ef7 on 1.0.x
    fix(#3638432): fit the content report table in admin themes
    

  • deciphered committed 68626ef7 on 1.1.x
    fix(#3638432): fit the content report table in admin themes
    
deciphered’s picture

Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.