Userpoints_flag - specify which flags earn points

Here is a patch that rewrites the module to allow per flag type points. It includes separate points and categories for the flagging user and flagged content author (or flagged user if it is a user flag). It also includes the daily threshold and moderation options per flag type.

Maybe the testbot will like this better.

Thanks for the patch, gilgabar. I have userpoints_contrib-6.x-1.0-beta1 and the patch from #3 applied without any issues and I was able to test it with a few different flags that we use. After applying the patch I had to clear the cache to get the settings page to show the Flag settings section correctly but after that it worked like a charm. Great work!

+++ userpoints_flag/userpoints_flag.module
@@ -1,123 +1,214 @@
+//$Id$

There should be a space before $Id$ but it doesn't matter as it will be removed anyway once we migrated to git (and that is soon!)

+++ userpoints_flag/userpoints_flag.module
@@ -1,123 +1,214 @@
+    // Load the category list.
+    $tree = taxonomy_get_tree(userpoints_get_vid());
+    $category_options = array();
+    $category_options[0] = t('!Uncategorized', userpoints_translation());
+    if (!empty($tree)) {
+      foreach ($tree as $term) {
+        $category_options[$term->tid] = str_repeat('--', $term->depth) . $term->name;
+      }
+    }

We usually don't indicate the term depth when displaying them in userpoints. You should also use the userpoints_get_categories() helper function.

+++ userpoints_flag/userpoints_flag.module
@@ -1,123 +1,214 @@
+            'operation' => 'flag_'. $flag->name,
+            'description' => t('Flag: !content_type !content_id.',array('!content_type'=> $flag->content_type, '!content_id'=> $content_id)),

- In Drupal 6, the operation is publicly shown. So it should probably use one or two "propper" words. In D7, that has changed. Is $flag->name the user facing name or is there something else that could be used instead?

- This needs to use @content_type/id.

Very nice work on this patch, will commit once you did a re-roll of the few minor things above.

Powered by Dreditor.

Thanks for the review Berdir. Rerolled patch fixes the space, implements userpoints_get_categories(), replaces $flag->name with $flag-title to be more human readable in the operation field as well as in the points settings form, and updates the text replacement with '@'.

The categories snippet is straight from userpoints_nc, so it looks like that should be patched as well.

Patch path was relative to userpoints_flag instead of userpoints_contrib.

Subscribing

Only did some brief testing, but this a huge improvement, thanks for the fast re-roll.

I was thinking about an upgrade path but that doesn't make much sense, chances are that all sites will want to re-visit their settings anyway. So all that could possibly be done is print a warning that the settings need to be re-visited, probably with a link point to those.

You're welcome to write a patch for that but I went ahead and commited this.

Is there any way to incorporate this patch into the D7 port of userpoints_flag that is underway on the following thread?

http://drupal.org/node/871116

--Ben

This patch works very well and saves my Web site.
All my congratulations !