userpoints_no_negative should not rely on php short tags [#282760]

The userpoints_no_negative module code opens with "<?" but should instead be changed to open with "<?php" as is standard with all other modules.

Using the 2-character short code requires that short_open_tag=On in php.ini, which many websites may not want to do.

./sites/all/modules/userpoints_contrib/userpoints_no_negative/userpoints_no_negative.module

Comment	File	Size	Author
#2	no_negative_short.diff	407 bytes	bovine

Comments

kbahey commented 15 July 2008 at 15:44

Status:

Active

» Needs work

Can you please create a patch for it? See http://drupal.org/patch for details.

bovine commented 15 July 2008 at 15:51

Status	File	Size
new	no_negative_short.diff	407 bytes

Ok, see attached.

kbahey commented 15 July 2008 at 16:58

Status:

Needs work

» Closed (duplicate)

This was fixed some time ago, here http://drupal.org/node/267774.

The file that is now in the -dev tarball should be:

2008-06-07 01:47 userpoints_no_negative.module

Older dates will not have the fix.