Problem/Motivation

Drupal modules can't be disabled, just uninstalled. For that reason, it makes sense to be able to disable the functionality temporarily.

So we should add an "enabled" (true by default) option. If disabled, the field should not be shown in the user profile and no redirect should happen. We should escape early everywhere.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork user_preference_login_redirect-3562398

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » lrwebks

Should be super easy, just a config setting and very early return.

lrwebks opened merge request !6

lrwebks made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: lrwebks » Unassigned
Status: Active » Reviewed & tested by the community

PERFECT, thank you!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » lrwebks
Status: Reviewed & tested by the community » Needs work

Ah sorry we need an update hook to set enabled TRUE in the config!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: lrwebks » Unassigned
Issue tags: +Novice

Anyone can do this, but maybe @lrwebks also :)

schillerm made their first commit to this issue’s fork.

schillerm’s picture

schillerm commented
Status: Needs work » Needs review

Hope that is ok.. please review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Thanks, I left a comment.

schillerm’s picture

schillerm commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Still wrong. @lrwebks can you please fix it finally?

lrwebks’s picture

lrwebks commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thank you!!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.