Problem/Motivation

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/uncached_status_page/README.md
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------
3 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters
4 | WARNING | [ ] Line exceeds 80 characters; contains 115 characters
28 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters
35 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

FILE: ...ahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/uncached_status_page/src/EventSubscriber/UncachedStatusPageSubscriber.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
35 | ERROR | [x] Data types in @param tags need to be fully namespaced
39 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/uncached_status_page

Proposed resolution

Fix the PHP coding standard issues.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3335599-2.patch2.05 KBsahil.goyal
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

sahil.goyal created an issue. See original summary.

sahil.goyal’s picture

StatusFileSize
new2.05 KB

fixing the php coding standard issue .

Charchil Khandelwal’s picture

Assigned: Unassigned » Charchil Khandelwal

Charchil Khandelwal’s picture

Assigned: Charchil Khandelwal » Unassigned
Status: Needs work » Reviewed & tested by the community

Patch #2 applied cleanly, and all errors and warnings are fixed.
So moving it to RTBC.
Thanks