Problem/Motivation

In PHP 8.4 it is deprecated to add a default value of a parameter as NULL, but not making it nullable.

Steps to reproduce

Try to run the module with PHP 8.4.

Proposed resolution

Mark the parameter as accepting null.

Remaining tasks

Add type declarations to the other methods as well ?

User interface changes

none

API changes

n/a

Data model changes

n/a

Issue fork ui_patterns_settings-3544366

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joao.ramos.costa created an issue. See original summary.

joao.ramos.costa opened merge request !49

joao.ramos.costa’s picture

joao.ramos.costa commented
Status: Active » Needs work

johnatas made their first commit to this issue’s fork.

johnatas’s picture

johnatas commented
Status: Needs work » Needs review

Hello,

Thank you @joao.ramos.costa.

I’ve just committed a fix to correct the use of a backslash instead of a pipe.

Everything is working correctly on my Drupal 11.3.3 project with UI Patterns Settings 2.4.0.

Moving the ticket to Needs review.

joao.ramos.costa’s picture

joao.ramos.costa commented

Hi @johnatas, ofc 🤦 ...

Thanks a lot.