Closed (fixed)
Project:
UC Linkpoint API
Version:
6.x-1.5
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Nov 2010 at 18:50 UTC
Updated:
29 Nov 2010 at 19:31 UTC
In this code:
$retarr = _uc_linkpoint_api_execute_txn($xml);
if ($retarr['r_approved'] == 'APPROVED') {
return TRUE;
}
else {
watchdog('uc_linkpoint_api', 'Unable to void transaction: !error', array('!error' => $error), WATCHDOG_ERROR);
return FALSE;
}
At least in version 1.5, $error isn't initialized anywhere. I'm guessing that should be referring to some part of the $retarr array instead. When you fix this, unless you're using secure messages explicitly defined by your module, you should also switch to the @ replacement type. Ya never know if the gateway might include some unescaped characters.
Comments
Comment #1
rszrama commentedAhh, looking in HEAD, I see that the watchdog() problem has already been addressed. I think this is a moot point now, as filter_xss_admin() is used on the display of order comments.