Closed (fixed)
Project:
UC Down Payment
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Dec 2011 at 03:52 UTC
Updated:
10 Apr 2015 at 17:00 UTC
Jump to comment: Most recent
Comments
Comment #1
sokrplare commentedWe are using the module with PayPal, but have only tried it with PayPal Pro, not Standard (or Express) which is where it sounds like the issue it cropping up. I'm surprised it breaks the Ubercart flow though, but would need to try it out again. Any chance you can write a patch for this? Would be glad to test and commit it!
Comment #2
ambereyes commentedTwo things I noticed:
1. Error in code at lines 279 & 253
$payment->pfid = $feature->pdif;should be$payment->pfid = $feature->pfid;2. Weight of module is 1 so it is run after the payment module(s) hook_order submit, maybe change to weight of 0 in system table.
I will test these changes over the next week or so.
Katrina
Comment #3
sokrplare commentedThank you. We have fixed the two errors, but we'll still have to review the weight options.
Comment #4
DBaumholzer commentedHi,
I also encountered the problem with paypal standard, it seems the information get lost when you redirect to an external site.
I will try with another payment provider.
Comment #5
DBaumholzer commentedI tested with another payment provider and the same issue. This needs to be fixed, it is very important. In europe only a standard paypal account is possible.
Thanks
Comment #6
sokrplare commentedThank you for your comments.
We believe that the problem mentioned by Katrina was identified: because module weight was 1, when using Paypal, you were sent to the Paypal website to make the payment, which totally skips the action of hook_order in the uc_downpayments module.
(Please note that uc_node_checkout module requires the uc_downpayments module to have the module weight at 1. For this reason using uc_downpayments, uc_node_checkout and Paypal in the same application does not seem to be feasible.)
Module weight was moved to 1 because of uc_node_checkout, however, given that using Paypal is probably more important, we have set the module weight back to -1.
Please check if you are using the most recent version (2012-Apr-13).
At this moment we are not in the position to spend time on further problem research and modifications related to this issue, so any working patch would be appreciated.
Comment #7
sokrplare commented