Needs review
Project:
Twitter Pull
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Nov 2015 at 16:41 UTC
Updated:
26 Nov 2015 at 16:56 UTC
Jump to comment: Most recent
If you fetch tweets from a Twitter user whose username contains an ampersand (e.g. "Foobar & Co.") then the username is rendered as "Foobar & Co.".
This seems to affect only the Twitter username.
I digged a bit in the code and it looks like we call check_plain() twice on the Twitter username:
twitter_pull.class.inctwitter-pull-listing.tpl.php: l() calls check_plain() unless we pass the array('html' => TRUE) optionA solution would be to pass the array('html' => TRUE) option to l() in the template file. This seems to be safe since we already call check_plain() when fetching the tweet.
Attached is a proposed patch that implements the above.
| Comment | File | Size | Author |
|---|---|---|---|
| twitter_pull-html_entities.patch | 951 bytes | fengtan |
Comments
Comment #2
fengtan