Closed (fixed)
Project:
Tour UI
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
23 Mar 2018 at 13:20 UTC
Updated:
22 Aug 2019 at 07:19 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
clemens.tolboomComment #3
clemens.tolboomComment #4
pvsureshmca commentedHi,
db_query is deprecated in the latest version, Please correct the Drupal coding standard error.
Comment #5
clemens.tolboomThanks for the review :-) (the image does not help). Deprecated is not bad per se.
What do you think of the idea? I personally find the textarea ugly but was not sure how to easily create an autocomplete URL / route matcher.
Ideas are welcome. Patches even more.
Comment #6
clemens.tolboomInstalling devel then visit devel/routes is now documented through the tour which is helpful but we can mimic the devel code which would be a good feature.
Comment #7
clemens.tolboomAttached new version.
The UI is not great. Should we add a collapsible fieldset? Should we get a table as response as #2978327: Allow configuration of route parameters adds route parameters too which are needed for the editing of the routes field.
Comment #8
clemens.tolboomComment #9
clemens.tolboomComment #10
clemens.tolboomComment #11
clemens.tolboomTyping node/12 does not work
Comment #12
mpp commentedAnother approach for this issue would be to provide a "Create tour" button:
- only show when the user has the permission to create tours;
- only show when there's no tour (in that case we could add an "Edit tour" button;
- link to the add tour page with the route (e.g. /admin/config/user-interface/tour/add?route=entity.media.add_form)
Comment #13
clemens.tolboom@mpp not sure your answer belongs to this issue right?
Comment #14
mpp commented@clemens.tolboom, we could open a new issue if you like but the real issue here is that it's hard (e.g. for an editor) to know what route belongs to a given path. The current approach is to simplify this by adding a "find route" widget. Another (or additional) way would to add a 'create tour' button that creates a tour for the current page. This way an editor would no longer need to fill in a route (or path, or install devel as I read in the documentation) in order to create a tour.
+ $list = [];
remove newline
Comment #15
clemens.tolboom@mpp IC ... that button sounds nice but is 'similar' as installing Devel and check the route as described on the project page. It should be a separate issue.
Maybe we should change 'Find route' into 'Find route or path'? I'll work on it and commit when done as this issue is open for too long.
Comment #16
clemens.tolboomDoh ... I should have added an autocomplete result screenshot!
You can search for a node path but only for route related entries ie not for aliases.
Comment #18
clemens.tolboomCommitted patch #7 plus textual change. It's good enough for me.
Comment #19
mpp commentedIt's definitely an improvement, thanks!
Comment #20
clemens.tolboom