I am not sure if this is an issue or not but config:inspect shows an issue here.
When running config:inspect of the config_inspector module, we get the following:

 ddev drush config:inspect --only-error --detail --list-constraints --filter-keys="tour.*"              ✱
➜  🤖 Analyzing…

 Legend for Data:
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ----------------- --------- ------------- ---------------------------------------------- -----------------------------
  Key               Status    Validatable   Data                                           Validation constraints
 ----------------- --------- ------------- ---------------------------------------------- -----------------------------
  tour.settings     Correct   100%          1 errors                                       ValidKeys: '<infer>'
                                                                                           LangcodeRequiredIfTranslata
                                                                                           bleValues: null
   tour.settings:   Correct   Validatable   The tour.settings config object must specify   ValidKeys: '<infer>'
                                            a language code, because it contains           LangcodeRequiredIfTranslata
                                            translatable values.                           bleValues: null
 ----------------- --------- ------------- ---------------------------------------------- -----------------------------

This comes from \Drupal\Core\Config\Plugin\Validation\Constraint\LangcodeRequiredIfTranslatableValuesConstraintValidator::validate which requires that the config object (the settings yml) has a langcode if it contains a translatable property.
Tour contains tour_avail_text and tour_no_avail_text designated as label which is a translatable string.

I suppose 2 things are needed here:
1. Define the langcode in the schema (I think it is optional)
2. Export the langcode when saving the settings form.

Issue fork tour-3585288

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dimilias created an issue. See original summary.

dimilias’s picture

Assigned: dimilias » Unassigned
Status: Active » Needs review
alorenc’s picture

Assigned: Unassigned » alorenc
alorenc’s picture

We need to add hook_update_N and set language in config/install/tour.settings.yml

alorenc’s picture

Assigned: alorenc » Unassigned
Status: Needs review » Needs work
alorenc’s picture

Status: Needs work » Reviewed & tested by the community