I've uninstalled this module and the "Topbar Message" content type still exists. This should definitely be removed upon uninstallation.

Comments

markwk’s picture

markwk commented
Category: Bug report » Support request

I'm not sure I agree with definitely nor do I agree this is a bug. It's quite intentional to leave the data structure and not assume the user wants that's gone. I'd say that what should be added is a warning message after installing that they should delete the content type too.

haysuess’s picture

haysuess commented

I would argue that "uninstall" means to actually uninstall everything a module installs in the first place to the majority of people. That's how every other module works. I've never come across another module that leaves things behind.

If I disable it, everything should remain in the database so it can be re-enabled at any time. If I uninstall it, EVERYTHING should be gone, just like software.

How else could someone know what else might have been left behind after an uninstall? Removing a module should mean 100% removing the module.

Another issue is that after the content type remained, it was locked. I had to go into my database and change the "custom" and "locked" values in the node_type table, flush my caches, and only then could I remove the content type.

wouser’s picture

wouser commented

I agree, I thought about using this module until I read this issue.

You have a great module here but the only thing that should exist after uninstalling is in the database, this is simply what users are "use to". It is especially scary when it comes to having to do maintenance to database to remove a content type; I would request this as a feature request.

1) Remove the content type when Module is disabled/uninstall
2) Allow users to delete the content type from the website without making any changes to database

markwk’s picture

markwk commented
Category: Support request » Feature request

I wouldn't quite call this scary but agree this is a feature request. It's a simple fix to add.

  • markwk committed ae45c3b on 7.x-1.x 
    Issue #2294509 by markwk: Uninstallation Should Remove "Topbar Message"...
markwk’s picture

markwk commented
Status: Active » Fixed

Went ahead and fixed this uninstall issue. Committed this to the 7.x-1.x dev branch and it should be part of the dev version now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.