Problem/Motivation

The aural view tests don't work for me.

I can change the announced messages in ToolbarAuralView.js, remove the announcements entirely, change the assertion to something that will definitely fail, or put bogus code in the callbacks, and the tests still pass.

It appears to be caused by a missing argument. The second argument of Nightwatch's .execute*() should be the arguments to be passed into the function that's specified in the first .execute*() argument.

Instead, the second argument is the callback.

There are other cases in that file where the second argument is the callback, so they may need to be changed as well. I haven't experimented with them yet.

Steps to reproduce

  1. In ToolbarAuralView.js, change one of the announced messages to something that certainly fail.
  2. Run the test.
Expected

The test will fail.

Actual

The test passes.

Proposed resolution

Add an empty array as the second argument to the .execute*() function.

#3090120: Improve accessibility semantics for Toolbar buttons with trays will remove the test for the tray toggle. In that case, only the Aural view test: tray orientation needs changing.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Comments

kentr created an issue. See original summary.

kentr’s picture

Issue summary: View changes
kentr’s picture

Issue summary: View changes

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

Status: Active » Postponed

The Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [meta] Tasks to remove Toolbar module.

Toolbar will be moved to a contributed project before Drupal 12.0.0 is released.

quietone’s picture

Project: Drupal core » Toolbar
Version: main » 1.x-dev
Component: toolbar.module » Code
Status: Postponed » Active

Toolbar has moved to contrib