Problem/Motivation

When we scroll on the vertical toolbar it also scrolls the main page behind it, and on scrolling, the header doesn't stick with the toolbar which doesn't look right. So if want to switch to shortcut options or admin options we have to scroll to the top of the page to see the header.

I've seen this issue in Chrome, Edge, and Firefox, I didn't check safari.

Expected Behaviour: The header should stick to the top when the side toolbar is expanded and when scrolling on the toolbar, it shouldn't scroll the main page behind it.

You can see the issue in the attached gif.

Steps to reproduce

TBA

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 After-scroll-fix.mov4.76 MBsheetal.pathak
#4 3347874-4.patch706 bytesjitender vaidh
#2 3347874-2.patch434 bytesjitender vaidh
toolbar-issue.gif3.72 MBkunals131

Issue fork drupal-3347874

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kunals131 created an issue. See original summary.

jitender vaidh’s picture

jitender vaidh
Primary language Hindi
commented
Status: Active » Needs review
StatusFileSize
new 3347874-2.patch434 bytes
smustgrave’s picture

smustgrave commented
Version: 10.0.x-dev » 11.x-dev
Status: Needs review » Postponed (maintainer needs more info)

This needs to be confirmed on 11.x

jitender vaidh’s picture

jitender vaidh
Primary language Hindi
commented
StatusFileSize
new 3347874-4.patch706 bytes

@smustgrave Ignoring the patch of comment no. 2 and the patch of comment no. 4, I have created a new patch for the 11.x-dev branch.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Needs work
Issue tags: -toolbar, -scrolling, - +Bug Smash Initiative, +Needs tests

I get the same result on a small screen size.

Are the duplicates of this issue?

I tested with Navigation and this does not happen. Since toolbar is a candidate for removal from core this may turn out to be a won't fix. #3476882: [Policy] Move Toolbar module to contrib

sheetal.pathak made their first commit to this issue’s fork.

sheetal.pathak opened merge request !9694

sheetal.pathak’s picture

sheetal.pathak commented
StatusFileSize
new After-scroll-fix.mov4.76 MB

Create MR to fix issue. Now header is sticking at top and scroll also working fine on small devices.

Drupal version 11.x-dev
Steps to reproduce

1. Open Admin menu on mobile device.
2. Open any menu when , when menu goes beyond screen scoll is working as expected.
3. Attaching screenshot for reference.

sheetal.pathak’s picture

sheetal.pathak commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

See tags

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [meta] Tasks to remove Toolbar module.

Toolbar will be moved to a contributed project before Drupal 12.0.0 is released.

quietone’s picture

quietone commented
Project: Drupal core » Toolbar
Version: main » 1.x-dev
Component: toolbar.module » Code
Status: Postponed » Needs work

Toolbar has moved to contrib