Problem/Motivation

Some top-level toolbar items have trays associated with them, while others don't. Currently there is no visual way to know which buttons have trays associated with them.

Screenshot of toolbar on Umami homepage. Description follows.
Here we see the the toolbar with 5 top-level items, and no tray is open. The manage, shortcuts, and admin (user menu) items all have trays associated with them, while the tour and edit buttons don't. There's no way to know which ones have a tray.

Screenshot of toolbar on an admin page. Description follows.
On an admin page, we see the the toolbar has a "back to site" link. 3 more top-level items (manage, shortcuts, and admin user menu) have trays associated with them, Again, there's no way to know which ones have a tray.

Toolbar items which have trays:

  • Manage
  • Shortcuts
  • User menu
  • Devel (contrib module)
  • Environment indicator (contrib module)

Toolbar items which don't have trays:

  • Home
  • Back to site
  • Tour
  • Edit

If toolbar items with tray had an indicator that they control a tray, it would help users to understand what their behaviour is.

The submenus inside the Manage tray already have icons for this, as do details/summary elements elsewhere in page content.

Proposed resolution

Add a visual signifier to toolbars items which have visual trays associated with them.

Scope:

Remaining tasks

  • Design.
  • Update CSS.
  • Tests? e.g. a functional test to confirm the presence of a CSS class on toolbar items with trays, and it's absence from toolbar items without trays.

User interface changes

Adds a visual indicator to show which toolbar buttons have trays associated with them.

API changes

None.

Data model changes

None.

Comments

andrewmacpherson created an issue. See original summary.

andrewmacpherson’s picture

Category: Task » Bug report
Issue summary: View changes
StatusFileSize
new21.34 KB
new23.95 KB
andrewmacpherson’s picture

Issue summary: View changes

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

andrewmacpherson’s picture

Issue tags: +Global2020

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

Status: Active » Postponed

The Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [meta] Tasks to remove Toolbar module.

Toolbar will be moved to a contributed project before Drupal 12.0.0 is released.

quietone’s picture

Project: Drupal core » Toolbar
Version: main » 1.x-dev
Component: toolbar.module » Code
Status: Postponed » Active

The Toolbar module have moved from core to contrib.