Node tokens not working for comment actions

Several questions:

1. Open 'token_node.inc' in an editor. Can you find the string 'author-mail' there? Perhaps you're using an old version.

2. Suppose you type some other node token in the recipient field, such as [author-name]. Will Token fail to expand it as well? Because if that's the case, then the problem isn't at all in the token [author-mail].

3. Suppose you type the [author-mail] token in the email body, will it get expanded correctly?

4. Do other node tokens expand correctly?

And why to you say "Drupal takes it [...]"? Drupal isn't involved here. Only the token module. Perhaps you're mistakenly using Drupal's own "send email" action?

Another idea: perhaps you have two versions of the module installed (in different folders) and Drupal happens to pick the older one.

So node tokens don't get expanded for you.

Do global tokens get expanded?

Global tokens as like [site-name], [site-date], [user-name], ...

And to which "trigger" did you assign the action?

so it's not a problem with triggers (I'm using the "Trigger: After saving a new comment" one).

It turns out to be a trigger problem.

The "After saving a new comment" trigger doesn't add the node object to the context. So the action doesn't see it.

The same happens with Drupal's own system_send_email_action(): it's the action itself which, given a comment, loads the node.

That's what we too should do.

I'm attaching a patch. In the same way we load 'user', so we should load 'node' --if a 'comment' object exists. I factored out the "normalization" process into a separate helper function.

This patch is working nicely for me too.

And I think there's duplicate patch at http://drupal.org/node/287614
(except the 'carriage return' issue)

Making the title more correct.

Patch is working well!

I am, however, still left without a working [url], [link] AND [path] token for comment actions. They are simply not substituted.

subscribing

Patch works fine for me too. Thanks. Tokens I'm using:

Recipient:
[author-mail]

Subject:
[site-name]
[type-name]
[title]

Message:
[comment-author-name]
[type-name]
[title]
[comment-body]
[site-url]
[comment-nid]
[comment-cid]
[site-url]
[nid]

This patch is working fine for me - any idea when it will be committed into the main module?

Does it really also work with the tokens I spoke of above, [url], [link] and [path]?

Actually [url], [link] and [path] aren't working for me.

Have noticed that there are two entries for these in the placeholder tokens section such as;

[url] Absolute path alias to the referenced user.

and

[url] Absolute path alias to the referenced node.

So i'm guessing this has something to do this.

I am succesfully using;

[author-name], [title], [site-url], [site-name], [comment-body]

If there are tokens that are the same between both node/user then that will definitely cause problems :( I'm not sure how to fix that - it's something that could be done during the upgrade to 7.x because it is a "major change requires manual intervention" kind of a thing. I created #412130: review all tokens for uniqueness and general sanity to cover that idea.

At first this patch felt overly complex to me (especially compared to the relatively lightweight change in #287614: support node tokens when a comment is posted in "send tokenized e-mail"). However, I think this reduces a lot of basically duplicate code and is a nice improvement.

Committed to 6.x branch. Thanks mooffie!